[PATCH] Cygwin: termios: Set ECHOE, ECHOK, ECHOCTL and ECHOKE by default.

Takashi Yano takashi.yano@nifty.ne.jp
Mon May 18 00:50:27 GMT 2020


On Mon, 18 May 2020 01:21:07 +0200
Kacper Michajlow via Cygwin-patches <cygwin-patches@cygwin.com> wrote:
> On Sun, 17 May 2020 at 04:53, Takashi Yano via Cygwin-patches <
> cygwin-patches@cygwin.com> wrote:
> 
> > - Backspace key does not work correctly in linux session opend by
> >   ssh from cygwin console if the shell is bash. This is due to lack
> >   of these flags.
> >
> >   Addresses: https://cygwin.com/pipermail/cygwin/2020-May/244837.html.
> > ---
> >  winsup/cygwin/fhandler_termios.cc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/winsup/cygwin/fhandler_termios.cc
> > b/winsup/cygwin/fhandler_termios.cc
> > index b6759b0a7..b03478b87 100644
> > --- a/winsup/cygwin/fhandler_termios.cc
> > +++ b/winsup/cygwin/fhandler_termios.cc
> > @@ -33,7 +33,8 @@ fhandler_termios::tcinit (bool is_pty_master)
> >        tc ()->ti.c_iflag = BRKINT | ICRNL | IXON | IUTF8;
> >        tc ()->ti.c_oflag = OPOST | ONLCR;
> >        tc ()->ti.c_cflag = B38400 | CS8 | CREAD;
> > -      tc ()->ti.c_lflag = ISIG | ICANON | ECHO | IEXTEN;
> > +      tc ()->ti.c_lflag = ISIG | ICANON | ECHO | IEXTEN
> > +       | ECHOE | ECHOK | ECHOCTL | ECHOKE;
> >
> >        tc ()->ti.c_cc[VDISCARD] = CFLUSH;
> >        tc ()->ti.c_cc[VEOL]     = CEOL;
> > --
> > 2.21.0
> >
> >
> Maybe also set  IXANY | IMAXBEL? For reasonable set of default values.

I don't think so, because they are not set also in xterm in linux.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>


More information about the Cygwin-patches mailing list