[newlib-cygwin/cygwin-3_0-branch] Cygwin: honor the O_PATH flag when opening a FIFO
Ken Brown
kbrown@sourceware.org
Thu Jun 27 11:18:00 GMT 2019
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=c4d5b61f1609589d98857f2ce2d8d7bcd94f2fa3
commit c4d5b61f1609589d98857f2ce2d8d7bcd94f2fa3
Author: Ken Brown <kbrown@cornell.edu>
Date: Wed Jun 26 20:44:16 2019 -0400
Cygwin: honor the O_PATH flag when opening a FIFO
Previously fhandler_fifo::open would treat the FIFO as a reader and
would block, waiting for a writer.
Diff:
---
winsup/cygwin/fhandler_fifo.cc | 11 ++++++++++-
winsup/cygwin/release/3.0.8 | 13 +++++++++++++
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/winsup/cygwin/fhandler_fifo.cc b/winsup/cygwin/fhandler_fifo.cc
index 5733ec7..9112314 100644
--- a/winsup/cygwin/fhandler_fifo.cc
+++ b/winsup/cygwin/fhandler_fifo.cc
@@ -85,11 +85,20 @@ fhandler_fifo::open (int flags, mode_t)
bool reader, writer, duplexer;
DWORD open_mode = FILE_FLAG_OVERLAPPED;
+ if (flags & O_PATH)
+ {
+ query_open (query_read_attributes);
+ nohandle (true);
+ }
+
/* Determine what we're doing with this fhandler: reading, writing, both */
switch (flags & O_ACCMODE)
{
case O_RDONLY:
- reader = true;
+ if (query_open ())
+ reader = false;
+ else
+ reader = true;
writer = false;
duplexer = false;
break;
diff --git a/winsup/cygwin/release/3.0.8 b/winsup/cygwin/release/3.0.8
new file mode 100644
index 0000000..e3734c9
--- /dev/null
+++ b/winsup/cygwin/release/3.0.8
@@ -0,0 +1,13 @@
+What's new:
+-----------
+
+
+What changed:
+-------------
+
+
+Bug Fixes
+---------
+
+- Fix a hang when opening a FIFO with O_PATH.
+ Addresses: https://cygwin.com/ml/cygwin-developers/2019-06/msg00001.html
More information about the Cygwin-cvs
mailing list